Check return values of every call to the hdf5 library#6029
Merged
Conversation
prckent
previously approved these changes
Jul 7, 2026
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Good idea.
Looks OK by eye; I hope not to have missed a subtle logic change.
Contributor
Author
|
Test this please |
prckent
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I was asking LLM to remove unused variables and realized that we should actually check return value of hdf5 calls. So I asked LLM to safeguard every necessary hdf5 call. It still needs a bit hand holding and I corrected a few sub-optimal lines.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
laptop
Checklist